Fixes to check_debug and adds support for Django 1.10 (the issues were heavily intertwined) #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2017
Closed
For DJ versions 1.8+
PamelaM
changed the title
PamelaM
commented
Jan 14, 2017
| if template_settings['BACKEND'] != 'django.template.backends.django.DjangoTemplates': | ||
| raise DjangoTemplatePluginException("Can't use non-Django templates.") | ||
| if not template_settings.get('OPTIONS', {}).get('debug', False): | ||
| if not settings.configured: |
There was a problem hiding this comment.
Here's how we defer check_debug until settings are configured. Note that we can't really encounter the case where we'd be tracing a template until after settings have been configured because the template can't be run without configured settings.
PamelaM
changed the title
|
@PamelaM !! Wow. Let me know when you are done with commits. Finding me on IRC or Slack would be cool too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a few issues:
django.template.backends.django.DjangoTemplatesat top-levelplugin_test.pyto avoid it getting reloaded.tox checkfailuresNot sure how to test that settings.py gets coverage in the current environment. I'm looking into creating a test_project that can be used for integration tests.